refactor : deprecate ParquetSource::predicate() and merge into FileSource::filter()
#17971
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
proto
getChan
changed the title
ParquetSource::predicate() and merge into FileSource::filter()
xudong963
approved these changes
Oct 11, 2025
|
Thanks @getChan and @xudong963 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
ParquetSourcecurrently defines a custompredicate()method whose behavior overlaps with thefilter()method in theFileSourcetrait. This duplication makes the API harder to understand.Suggest deprecating
predicate()and relying onfilter()for a single, consistent entry point.What changes are included in this PR?
deprecating
predicate()Are these changes tested?
unit tested
Are there any user-facing changes?
deprecating
predicate()public method